[flang-commits] [flang] [flang] Change `uniqueCGIdent` separator from `.` to `_` (PR #71338)

[via flang-commits]

jeanPerier wrote:

If it makes things easier, I think a more generic solution could also be to deal with this when dealing with the target aspects of the IR in the stage that lowers FIR to LLVM IR like the ExternalNameConversion pass https://github.com/llvm/llvm-project/blob/main/flang/lib/Optimizer/Transforms/ExternalNameConversion.cpp.

FIR symbol names do not have to be the assembly names already (and are not in the case of external subroutine/common blocks).

Although I am OK with the character and array litteral change in FIR that you have, they do not change the complexity and readability. Dealing with the derived type descriptor data may be a bit more complex to avoid collision with user defined symbols. And yes, it is OK with me and better to split the patches since they are touching a lot of test files.

https://github.com/llvm/llvm-project/pull/71338