[flang-commits] [PATCH] D150159: [flang] CUDA Fortran - part 1/5: parsing

[Brad Richardson via Phabricator via flang-commits]

everythingfunctional added a comment.

In D150159#4346752 <https://reviews.llvm.org/D150159#4346752>, @klausler wrote:

> In D150159#4346067 <https://reviews.llvm.org/D150159#4346067>, @everythingfunctional wrote:
>
>> I'm fairly sympathetic to @MehdiChinoune 's argument here. You're essentially asking an open-source community to support your proprietary technology. Maybe it's widely enough used that it deserves to be (I'm at least open to the argument), but you should definitely be open and upfront about wanting to do that, and ask the community through the proper procedures first. I think it would have a been a violation of the community's trust if it had been approved and made it into the official repository without anybody outside Nvidia having a chance to comment. Maybe I missed it, but I don't remember hearing about this plan before the patches got submitted. And based on the number of reviewers listed here, it doesn't look like you were trying to publicise it very broadly.
>
> I've left these reviews open for comment for a long time, and will continue to do so to collect relevant comments from people who actually participate in the project.

But my point was that you have not actually solicited feedback from **everybody** who "actually participates," only those actively monitoring every submission to Phabricator. Some people can't actively monitor every submission, since many people contribute on a voluntary or part time basis, and I think their opinions matter too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150159/new/

https://reviews.llvm.org/D150159