[flang-commits] [PATCH] D150564: [flang][hlfir] Implement hlfir.forall codegen when no temp is required

[Jean Perier via Phabricator via flang-commits]

jeanPerier marked 4 inline comments as done.
jeanPerier added a comment.

Thanks for the reviews



================
Comment at: flang/lib/Optimizer/HLFIR/Transforms/LowerHLFIROrderedAssignments.cpp:46
+namespace {
+/// Structure that visits an ordered assignment tree and generate code for
+/// it according to a schedule.
----------------
tschuett wrote:
> generates?
Thanks


================
Comment at: flang/lib/Optimizer/HLFIR/Transforms/LowerHLFIROrderedAssignments.cpp:83
+  /// Are they any leaf region in node that must be saved in the current run?
+  bool mustSavedRegionIn(hlfir::OrderedAssignmentTreeOpInterface &node);
+  /// Should this node be evaluated in the current run? Saving a region in a
----------------
tschuett wrote:
> no const?
Thanks, the ref is actually no needed. MLIR values/operations should be passed by value. However, added it the method.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150564/new/

https://reviews.llvm.org/D150564