[flang-commits] [PATCH] D150455: [flang][hlfir] Implement the scheduling part of hlfir.forall codegen

[Slava Zakharin via Phabricator via flang-commits]

vzakhari added a comment.

Looks great! Thank you, Jean!



================
Comment at: flang/lib/Optimizer/HLFIR/Transforms/ScheduleOrderAssignments.cpp:257
+/// if it could be proved that the variable are different sub-part of
+/// and array).
+static mlir::Value getStorageSource(mlir::Value var) {
----------------



================
Comment at: flang/lib/Optimizer/HLFIR/Transforms/ScheduleOrderAssignments.cpp:345
+  // Yield has no effect as such, but in the context of order assignments.
+  // the order assignments will usually read the yielded entity (except for
+  // the yielded assignments LHS that is only read if this is an assignment
----------------



================
Comment at: flang/lib/Optimizer/HLFIR/Transforms/ScheduleOrderAssignments.cpp:416
+void Scheduler::finishSchedulingAssignment(hlfir::RegionAssignOp assign) {
+  // For now, always schedule each assignment in its won run. They could
+  // be done as part of previous assignment runs if it is proven they have
----------------



================
Comment at: flang/lib/Optimizer/HLFIR/Transforms/ScheduleOrderAssignments.cpp:442
+
+/// Gather the hlfir.region assign nested directly and indirectly inside root in
+/// execution order.
----------------



================
Comment at: flang/lib/Optimizer/HLFIR/Transforms/ScheduleOrderAssignments.cpp:480
+
+// Build the list of the parent nodes for this assignment. The list is build
+// from the closest parent until the ordered assignment tree root (this is the
----------------



================
Comment at: flang/lib/Optimizer/HLFIR/Transforms/ScheduleOrderAssignments.cpp:528
+    // The LHS yield has no implicit read effect on the produced variable (the
+    // varibale is not read before the assignment).
+    scheduler.startIndependentEvaluationGroup();
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150455/new/

https://reviews.llvm.org/D150455