[flang-commits] [PATCH] D149878: [flang][hlfir] Lower forall to HLFIR

[Slava Zakharin via Phabricator via flang-commits]

vzakhari accepted this revision.
vzakhari added a comment.
This revision is now accepted and ready to land.

Looks great!



================
Comment at: flang/lib/Lower/Bridge.cpp:2048
+      mlir::OpBuilder::InsertPoint innerInsertionPoint;
+      if (outerForall && !isMask) {
+        innerInsertionPoint = builder->saveInsertionPoint();
----------------
Why cannot we do the same for the masked case?


================
Comment at: flang/lib/Lower/Bridge.cpp:3127
+          loc, *this, assign.rhs, localSymbols, stmtCtx);
+      // Load trivial scalar LHS to allow the loads to be
+      // hoisted outside of loops early if possible. This also
----------------
typo: `LHS` -> `RHS`


================
Comment at: flang/lib/Lower/Bridge.cpp:3156
+    // Assignments inside Forall, Where, or assignments to a vector subscripted
+    // right hand side requires using an hlfir.region_assign in HLFIR. The
+    // right hand side and left hand side must be evaluated inside the
----------------
typo: `right` -> `left`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149878/new/

https://reviews.llvm.org/D149878