[flang-commits] [PATCH] D149865: [fortran] Disable some gfortran tests that non-determinstically fail when testing in parallel

[Tarun Prabhu via Phabricator via flang-commits]

tarunprabhu created this revision.
tarunprabhu added reviewers: jeanPerier, klausler, kiranchandramohan.
tarunprabhu added a project: Flang.
Herald added a subscriber: jdoerfert.
Herald added a project: All.
tarunprabhu requested review of this revision.

Several gfortran tests read/write/delete the same file. When running the test suite in parallel, this results in non-deterministic test failures since the tests race on the file. This disables several tests that have such implicit race conditions.

A better approach would be to have the tests run in their own temporary directory, or to have lit run just those tests serially. I will look into those options and put up a patch. This is to quickly work around the non-deterministic failures in the buildbots such as (among several others):

https://lab.llvm.org/buildbot/#/builders/197/builds/4630
https://lab.llvm.org/buildbot/#/builders/197/builds/4640


Repository:
  rT test-suite

https://reviews.llvm.org/D149865

Files:
  Fortran/gfortran/regression/CMakeLists.txt


Index: Fortran/gfortran/regression/CMakeLists.txt
===================================================================
--- Fortran/gfortran/regression/CMakeLists.txt
+++ Fortran/gfortran/regression/CMakeLists.txt
@@ -1845,6 +1845,41 @@
   # anyway so the test-suite passes by default on AArch64.
   entry_23.f
   findloc_8.f90
+
+  # These tests have race conditions with other tests that cause them to
+  # occasionally fail when run in parallel. Every test in each group listed
+  # below has a race condition with at least one other test in the group.
+
+  # <group> Tests read/write/replace/delete file named 'tmp.dat'
+  pr88169_1.f90
+  pr88169_2.f90
+  pr88169_3.f90
+  list_read_6.f90
+  # </group>
+
+  # <group>
+  write_rewind_1.f
+  write_rewind_2.f
+  # </group>
+
+  # <group> Tests read/delete/append file named 'foo'
+  append_1.f90
+  large_unit_2.f90
+  open_access_append_1.f90
+  open_status_1.f90
+  # </group>
+
+  # <group> Tests create/replace file named 'test.dat'
+  direct_io_12.f90
+  endfile.f90
+  eof_4.f90
+  implied_do_io_1.f90
+  list_read_7.f90
+  namelist_76.f90
+  read_eof_8.f90
+  read_eof_all.f90
+  streamio_18.f90
+  # </group>
 )
 
 list(APPEND UnsupportedTests "${Unsupported}")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149865.519518.patch
Type: text/x-patch
Size: 1222 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20230504/f8f4d947/attachment-0001.bin>