[flang-commits] [flang] 83478a1 - [flang][openacc] Add proper TODO for reduction lowering

[Valentin Clement via flang-commits]

Author: Valentin Clement
Date: 2023-05-03T15:43:57-07:00
New Revision: 83478a1e5293f56627cdacafa9b5a07788aee374

URL: https://github.com/llvm/llvm-project/commit/83478a1e5293f56627cdacafa9b5a07788aee374
DIFF: https://github.com/llvm/llvm-project/commit/83478a1e5293f56627cdacafa9b5a07788aee374.diff

LOG: [flang][openacc] Add proper TODO for reduction lowering

Reduction clause on loop or compute constructs
is not currently lowered but no TODO message was issued.
Add a proper TODO so the user is informed.

Reviewed By: razvanlupusoru

Differential Revision: https://reviews.llvm.org/D149789

Added: 
    

Modified: 
    flang/lib/Lower/OpenACC.cpp

Removed: 
    


################################################################################
diff  --git a/flang/lib/Lower/OpenACC.cpp b/flang/lib/Lower/OpenACC.cpp
index fc7656ef9a27..2054ae78f9c6 100644
--- a/flang/lib/Lower/OpenACC.cpp
+++ b/flang/lib/Lower/OpenACC.cpp
@@ -671,9 +671,11 @@ createLoopOp(Fortran::lower::AbstractConverter &converter,
                        &clause.u)) {
       genObjectList(privateClause->v, converter, semanticsContext, stmtCtx,
                     privateOperands);
+    } else if (std::get_if<Fortran::parser::AccClause::Reduction>(&clause.u)) {
+      // Reduction clause is left out for the moment as the clause will probably
+      // end up having its own operation.
+      TODO(clauseLocation, "OpenACC compute construct reduction lowering");
     }
-    // Reduction clause is left out for the moment as the clause will probably
-    // end up having its own operation.
   }
 
   // Prepare the operand segment size attribute and the operands value range.
@@ -888,6 +890,8 @@ createComputeOp(Fortran::lower::AbstractConverter &converter,
                        &clause.u)) {
       genObjectList(firstprivateClause->v, converter, semanticsContext, stmtCtx,
                     firstprivateOperands);
+    } else if (std::get_if<Fortran::parser::AccClause::Reduction>(&clause.u)) {
+      TODO(clauseLocation, "compute construct reduction clause lowering");
     }
   }