[flang-commits] [PATCH] D149734: [flang][hlfir] Add hlfir.forall and its OrderAssignmentTreeOpInterface

[Slava Zakharin via Phabricator via flang-commits]

vzakhari accepted this revision.
vzakhari added a comment.

Looks great, Jean!  I have just one question.



================
Comment at: flang/include/flang/Optimizer/HLFIR/HLFIROps.td:1069
+
+    A Fortran forall with several indices is represented as a nest
+    of hlfir.forall.
----------------
Sounds okay, but would we have more readable IR if we support multiple indices with a single `hlfir.forall`?  Having `hlfir.yield` return a vector of ints and having multiple blocks arguments in the body block does not sound too complex.  Will it make the lowering more complex?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149734/new/

https://reviews.llvm.org/D149734