[flang-commits] [PATCH] D146475: Add tests from gfortran test-suite [Patch 1 of 6]

Tue Mar 21 12:24:54 PDT 2023

tarunprabhu added a subscriber: lenary.
tarunprabhu added a comment.

In D146475#4209893 <https://reviews.llvm.org/D146475#4209893>, @klausler wrote:

> Who owns the copyright to these files, and does their license permit you to copy them into this repository with its license?

The files are from GCC's testsuite. To the best of my knowledge, they are licensed under GPL/GPLv3 which allows us to copy them into this repository with that license. The license files are included in a separate patch <https://reviews.llvm.org/D146485> which will be committed together with this one.

@lenary did something similar <https://reviews.llvm.org/D66887?id=217870> with GCC's C torture tests. Per his comment <https://discourse.llvm.org/t/add-gfortran-tests-to-llvm-test-suite/69408/3?u=tarunprabhu>, we do not want to make any changes to the files themselves, so simply importing them with the correct license should mean that we are in compliance.

> How with changes made to the original files in the future make their way to this copy?

As I understand it, any changes would have to be brought over manually. I don't know if there is some automation somewhere that periodically pulls in changes.

> Could you instead create a script that rsyncs these tests to a local cache and runs f18 against them from there?

That is a possibility. The same issue was raised <https://lists.llvm.org/pipermail/llvm-dev/2019-September/134902.html> when adding the C torture tests. At the time, there was more inclination towards importing the tests which is why I did the same here.

Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146475/new/

https://reviews.llvm.org/D146475