[flang-commits] [PATCH] D146485: Add tests from gfortran test suite [build files]

[Sam Elliott via Phabricator via flang-commits]

lenary added a reviewer: lenary.
lenary added a comment.

I only have one comment, beyond that this looks pretty good to me. Please don't forget the licensing info, it's fairly important to add either with or before the test sources are added, so we are totally clear on what is going on. Note with the C test suite, I landed the CMake first, and then the GPL-licensed test sources, rather than the other way around.



================
Comment at: Fortran/gfortran/regression/CMakeLists.txt:53
+# Some tests in the suite are unsupported for one reason or another.
+file(GLOB UnsupportedTests CONFIGURE_DEPENDS
+  #
----------------
If you look in `SingleSource/Regression/C/gcc-c-torture/execute/CMakeLists.txt`, i did try to separate out `UnsupportedTests` were ones that would never be supported, whereas `FailingTests` are ones that we should at some point fix. It better documents which of the lists should get smaller over time, and if we end up supporting XFAILs, then we would get even better information from the test suite.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146485/new/

https://reviews.llvm.org/D146485