[flang-commits] [flang] 7cc4e98 - [flang] Accept non-interoperable LOGICAL scalar dummy arguments

[Peter Klausler via flang-commits]

Author: Peter Klausler
Date: 2023-03-13T17:58:42-07:00
New Revision: 7cc4e980e0f4032fd1bc4a736a9944c59aeff726

URL: https://github.com/llvm/llvm-project/commit/7cc4e980e0f4032fd1bc4a736a9944c59aeff726
DIFF: https://github.com/llvm/llvm-project/commit/7cc4e980e0f4032fd1bc4a736a9944c59aeff726.diff

LOG: [flang] Accept non-interoperable LOGICAL scalar dummy arguments

Some Fortran compilers allow kinds of LOGICAL other than C_BOOL
for the types of dummy arguments to interoperable (BIND(C))
procedures.  As any kind of LOGICAL can be converted to any
other without loss of information, this seems to be a useful
unambiguous extension that is attested in real codes; accept it
for scalars with a portability warning.

Differential Revision: https://reviews.llvm.org/D145968

Added: 
    

Modified: 
    flang/docs/Extensions.md
    flang/lib/Semantics/check-declarations.cpp
    flang/test/Semantics/bind-c11.f90

Removed: 
    


################################################################################
diff  --git a/flang/docs/Extensions.md b/flang/docs/Extensions.md
index 31fc3a7bc801c..4f68007418c51 100644
--- a/flang/docs/Extensions.md
+++ b/flang/docs/Extensions.md
@@ -266,6 +266,9 @@ end
   enforce it and the constraint is not necessary for a correct
   implementation.
 * A label may follow a semicolon in fixed form source.
+* A scalar logical dummy argument to a `BIND(C)` procedure does
+  not have to have `KIND=C_BOOL` since it can be converted to/from
+  `_Bool` without loss of information.
 
 ### Extensions supported when enabled by options
 

diff  --git a/flang/lib/Semantics/check-declarations.cpp b/flang/lib/Semantics/check-declarations.cpp
index 702d4fbf6b248..b7c82a4942636 100644
--- a/flang/lib/Semantics/check-declarations.cpp
+++ b/flang/lib/Semantics/check-declarations.cpp
@@ -2269,7 +2269,8 @@ void CheckHelper::CheckBindC(const Symbol &symbol) {
           "A variable with BIND(C) attribute may only appear in the specification part of a module"_err_en_US);
       context_.SetError(symbol);
     }
-    if (auto shape{evaluate::GetShape(foldingContext_, symbol)}) {
+    auto shape{evaluate::GetShape(foldingContext_, symbol)};
+    if (shape) {
       if (evaluate::GetRank(*shape) == 0) { // 18.3.4
         if (isExplicitBindC && IsAllocatableOrPointer(symbol)) {
           messages_.Say(symbol.name(),
@@ -2310,6 +2311,13 @@ void CheckHelper::CheckBindC(const Symbol &symbol) {
         // ok; F'2018 18.3.6 p2(6)
       } else if (derived || IsInteroperableIntrinsicType(*type)) {
         // F'2018 18.3.6 p2(4,5)
+      } else if (type->category() == DeclTypeSpec::Logical && IsDummy(symbol) &&
+          evaluate::GetRank(*shape) == 0) {
+        // Special exception: LOGICAL scalar dummy arguments can be converted
+        // before a call -- & after if not INTENT(IN) -- without loss of
+        // information, and are accepted by some older compilers.
+        messages_.Say(symbol.name(),
+            "A BIND(C) LOGICAL dummy argument should have the interoperable KIND=C_BOOL"_port_en_US);
       } else if (symbol.attrs().test(Attr::VALUE)) {
         messages_.Say(symbol.name(),
             "A BIND(C) VALUE dummy argument must have an interoperable type"_err_en_US);

diff  --git a/flang/test/Semantics/bind-c11.f90 b/flang/test/Semantics/bind-c11.f90
index 06f5c05c511d1..29ae09bd39f89 100644
--- a/flang/test/Semantics/bind-c11.f90
+++ b/flang/test/Semantics/bind-c11.f90
@@ -8,7 +8,7 @@ module m
   real, allocatable, bind(c) :: x3(:)
  contains
   subroutine s1(x) bind(c)
-    !ERROR: A BIND(C) VALUE dummy argument must have an interoperable type
+    !PORTABILITY: A BIND(C) LOGICAL dummy argument should have the interoperable KIND=C_BOOL
     logical(2), intent(in), value :: x
   end
   subroutine s2(x) bind(c)