[flang-commits] [PATCH] D154230: [flang][hlfir] probe ultimate intrinsic module procedure name

[Jean Perier via Phabricator via flang-commits]

jeanPerier created this revision.
jeanPerier added reviewers: vzakhari, tblah.
jeanPerier added a project: Flang.
Herald added subscribers: sunshaoce, mehdi_amini, jdoerfert.
Herald added a project: All.
jeanPerier requested review of this revision.

HLFIR lowering was currently hitting errors like "not yet implemented:
intrinsic: z0$iso_c_binding$c_associated_c_ptr". These error were caused
by HLFIR lowering using the name with the full context instead of
the ultimate one.
I do not want to change proc.GetName() because I think it may be best
if it retains the full context for its usages in semantics, so I fixed
the helper to get the name in lowering to HLFIR.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154230

Files:
  flang/lib/Lower/ConvertCall.cpp
  flang/test/Lower/HLFIR/intrinsic-module-procedures.f90


Index: flang/test/Lower/HLFIR/intrinsic-module-procedures.f90
===================================================================
--- flang/test/Lower/HLFIR/intrinsic-module-procedures.f90
+++ flang/test/Lower/HLFIR/intrinsic-module-procedures.f90
@@ -21,3 +21,14 @@
 ! CHECK:         %[[VAL_8:.*]] = fir.box_addr %[[VAL_4]] : (!fir.box<i32>) -> !fir.ref<i32>
 ! CHECK:         %[[VAL_9:.*]] = fir.convert %[[VAL_8]] : (!fir.ref<i32>) -> i64
 ! CHECK:         fir.store %[[VAL_9]] to %[[VAL_7]] : !fir.ref<i64>
+
+subroutine test_renaming(p)
+  use iso_c_binding, only: c_associated_alias => c_associated, c_ptr
+  type(c_ptr) p
+  print *, c_associated_alias(p)
+end subroutine
+
+! CHECK-LABEL: func.func @_QPtest_renaming
+! CHECK:  %[[C_PTR_TARG:.*]] = fir.load %{{.*}} : !fir.ref<i64>
+! CHECK:  %[[NULL:.*]] = arith.constant 0 : i64
+! CHECK:  arith.cmpi ne, %[[C_PTR_TARG]], %[[NULL]] : i64
Index: flang/lib/Lower/ConvertCall.cpp
===================================================================
--- flang/lib/Lower/ConvertCall.cpp
+++ flang/lib/Lower/ConvertCall.cpp
@@ -583,7 +583,11 @@
 
   fir::FirOpBuilder &getBuilder() { return converter.getFirOpBuilder(); }
 
-  std::string getProcedureName() const { return procRef.proc().GetName(); }
+  std::string getProcedureName() const {
+    if (const Fortran::semantics::Symbol *sym = procRef.proc().GetSymbol())
+      return sym->GetUltimate().name().ToString();
+    return procRef.proc().GetName();
+  }
 
   /// Is this a call to an elemental procedure with at least one array argument?
   bool isElementalProcWithArrayArgs() const {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154230.536286.patch
Type: text/x-patch
Size: 1599 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20230630/a55dadfe/attachment.bin>