[flang-commits] [PATCH] D154057: [flang][hlfir] Codegen of hlfir.region_assign where LHS conflicts

[Slava Zakharin via Phabricator via flang-commits]

vzakhari accepted this revision.
vzakhari added a comment.

Thank you, Jean!



================
Comment at: flang/include/flang/Optimizer/Builder/TemporaryStorage.h:179
+/// rank. Each variable may have different type parameters, bounds, and dynamic
+/// type. Fetching variable N will return a variable with the same, address,
+/// dynamic type, bounds, and type parameters as the Nth variable that was
----------------
nit


================
Comment at: flang/lib/Optimizer/Builder/TemporaryStorage.cpp:283
+  // The runtime always tracks variable as address, but the form of the variable
+  // that was saved may be different (raw address, fir.boxchar), ensure the
+  // the returned variable has the same form of the one that was saved.
----------------
nit


================
Comment at: flang/lib/Optimizer/HLFIR/Transforms/LowerHLFIROrderedAssignments.cpp:709
+    if (elementalAddrLhs && !whereLoopNest) {
+      // Vector subscripted designator address are saved element by elements.
+      // if no "elemental" loops have been created yet, the shape of the
----------------
nit


================
Comment at: flang/lib/Optimizer/HLFIR/Transforms/LowerHLFIROrderedAssignments.cpp:710
+      // Vector subscripted designator address are saved element by elements.
+      // if no "elemental" loops have been created yet, the shape of the
+      // RHS, if it is an array can be used, or the shape of the vector
----------------
nit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154057/new/

https://reviews.llvm.org/D154057