[flang-commits] [PATCH] D153516: [flang][hlfir] user defined assignment codegen

[Jean Perier via Phabricator via flang-commits]

jeanPerier added inline comments.


================
Comment at: flang/lib/Optimizer/HLFIR/Transforms/LowerHLFIROrderedAssignments.cpp:389
+    cleanups.emplace_back([=]() { b->create<hlfir::DestroyOp>(loc, asExpr); });
+    return hlfir::Entity{asExpr};
+  }
----------------
tblah wrote:
> Thanks for fixing. I think this needs a convert as well
This one is more tricky. So far there is no conversion at the hlfir.expr level, and I think trying to modify the input would increase the risk of bug more than anything. I do not expect that the T can mismatch here, although there is indeed nothing that reliably prevents it. So for now, I added a TODO in case there is mismatch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153516/new/

https://reviews.llvm.org/D153516