[flang-commits] [PATCH] D153431: [Fortran/gfortran] Enable OpenMP "compile" tests in gfortran test suite

Tarun Prabhu via Phabricator via flang-commits flang-commits at lists.llvm.org
Wed Jun 21 08:17:25 PDT 2023


tarunprabhu created this revision.
tarunprabhu added reviewers: kiranchandramohan, luporl, PeteSteinfeld, klausler.
tarunprabhu added a project: Flang.
Herald added subscribers: sunshaoce, ormris, jdoerfert, steven_wu, guansong, hiraditya, yaxunl.
Herald added a reviewer: sscalpone.
Herald added a project: All.
tarunprabhu requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: jplehr, sstefan1.

In addition to enabling the OpenMP "compile" tests, this also does the following:

Major reorganization of the build files. A lot of duplicated code was consolidated into a single location.

Cleanup of the build files.

The disabled tests are moved into their own file in each subdirectory instead of being present in the CMakeLists.txt file. Since we might want to eventually automate/semi-automate the process of enabling tests as features are added to flang, it seemed safer to have the list in a separate file where it could be parsed with a script instead of being embedded with other code.

The readme has been updated to reflect the newly enabled tests. Todo's have been added to it highlighting the limitations of the approach taken when enabling these tests.

For the moment, I have relied on the test command being present - either as part of the shell or a separate command in *nix systems (the tests are not enabled on Windows anyway). I am not sure if this reasonable and I am open to alternatives. What is really needed is LLVM's `not` utility to invert the return code of a diff utility. But that will require the build directory to be accessible at test-time and/or the not utility to be present on the system. I am not sure if we can rely on either of those.


Repository:
  rT test-suite

https://reviews.llvm.org/D153431

Files:
  Fortran/gfortran/CMakeLists.txt
  Fortran/gfortran/README.md
  Fortran/gfortran/compile-save-diags.cmake
  Fortran/gfortran/regression/CMakeLists.txt
  Fortran/gfortran/regression/DisabledFiles.cmake
  Fortran/gfortran/regression/analyzer/CMakeLists.txt
  Fortran/gfortran/regression/analyzer/DisabledFiles.cmake
  Fortran/gfortran/regression/asan/CMakeLists.txt
  Fortran/gfortran/regression/asan/DisabledFiles.cmake
  Fortran/gfortran/regression/c-interop/CMakeLists.txt
  Fortran/gfortran/regression/c-interop/DisabledFiles.cmake
  Fortran/gfortran/regression/coarray/CMakeLists.txt
  Fortran/gfortran/regression/coarray/DisabledFiles.cmake
  Fortran/gfortran/regression/debug/CMakeLists.txt
  Fortran/gfortran/regression/debug/DisabledFiles.cmake
  Fortran/gfortran/regression/g77/CMakeLists.txt
  Fortran/gfortran/regression/g77/DisabledFiles.cmake
  Fortran/gfortran/regression/goacc-gomp/CMakeLists.txt
  Fortran/gfortran/regression/goacc-gomp/DisabledFiles.cmake
  Fortran/gfortran/regression/goacc/CMakeLists.txt
  Fortran/gfortran/regression/goacc/DisabledFiles.cmake
  Fortran/gfortran/regression/gomp/CMakeLists.txt
  Fortran/gfortran/regression/gomp/DisabledFiles.cmake
  Fortran/gfortran/regression/gomp/appendix-a/CMakeLists.txt
  Fortran/gfortran/regression/gomp/appendix-a/DisabledFiles.cmake
  Fortran/gfortran/regression/graphite/CMakeLists.txt
  Fortran/gfortran/regression/guality/CMakeLists.txt
  Fortran/gfortran/regression/ieee/CMakeLists.txt
  Fortran/gfortran/regression/ieee/DisabledFiles.cmake
  Fortran/gfortran/regression/lto/CMakeLists.txt
  Fortran/gfortran/regression/lto/DisabledFiles.cmake
  Fortran/gfortran/regression/prof/CMakeLists.txt
  Fortran/gfortran/regression/ubsan/CMakeLists.txt
  Fortran/gfortran/regression/ubsan/DisabledFiles.cmake
  Fortran/gfortran/regression/vect/CMakeLists.txt
  Fortran/gfortran/regression/vect/DisabledFiles.cmake
  Fortran/gfortran/torture/CMakeLists.txt
  Fortran/gfortran/torture/compile/CMakeLists.txt
  Fortran/gfortran/torture/compile/DisabledFiles.cmake
  Fortran/gfortran/torture/execute/CMakeLists.txt
  Fortran/gfortran/torture/execute/DisabledFiles.cmake

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153431.533263.patch
Type: text/x-patch
Size: 200345 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20230621/ba065b67/attachment-0001.bin>


More information about the flang-commits mailing list