[flang-commits] [PATCH] D152307: [Fortran/gfortran] Fix build-time and test-time race conditions

Kiran Chandramohan via Phabricator via flang-commits flang-commits at lists.llvm.org
Wed Jun 7 07:39:55 PDT 2023


kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

Nice. This change worked fine for me on an AArch64 machine. The idea of using a working directory to compile and run makes sense and would help avoid different tests with the same module name overwriting each other or tests that create files and writes/read from interfering with each other.



================
Comment at: Fortran/gfortran/CMakeLists.txt:276-278
+  # It may be "cleaner" to have separate directories - one that serves as the
+  # module directory and the other as the working directory, but that is
+  # probably unnecessary.
----------------
Makes sense.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152307/new/

https://reviews.llvm.org/D152307



More information about the flang-commits mailing list