[flang-commits] [PATCH] D150164: [flang] CUDA Fortran - part 5/5: statement semantics

[Thorsten via Phabricator via flang-commits]

tschuett added inline comments.


================
Comment at: flang/include/flang/Parser/tools.h:175
+    } else {
+      return {};
+    }
----------------
Result is an using optional. Why braces?


================
Comment at: flang/include/flang/Parser/tools.h:183
+    } else {
+      return {};
+    }
----------------
stud:nullopt?


================
Comment at: flang/include/flang/Parser/tools.h:201
+    }
+    return {};
+  }
----------------
And more.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150164/new/

https://reviews.llvm.org/D150164