[flang-commits] [PATCH] D142695: [flang][hlfir] Lower post f77 user calls

[Pete Steinfeld via Phabricator via flang-commits]

PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.

Aside from the nits on the comments, all builds and tests correctly and looks good.



================
Comment at: flang/lib/Lower/ConvertCall.cpp:630
+
+/// Structure to help conditionnaly preparing a dummy argument based
+/// on the actual argument present.
----------------
"conditionnaly" should be "conditionally"


================
Comment at: flang/lib/Lower/ConvertCall.cpp:635
+///
+///  %conditionnalyPrepared = fir.if (%present) {
+///    fir.result %preparedDummy
----------------
Should this be "%conditionallyPrepared"?


================
Comment at: flang/lib/Lower/ConvertCall.cpp:691
+
+  /// Once the fir.if has been created, get the resulting %conditionnalyPrepared
+  /// dummy argument.
----------------
Should read "%conditionallyPrepared".


================
Comment at: flang/lib/Lower/ConvertCall.cpp:828
+    // polymorphic might unconditionally read the addendum. Intrinsic type
+    // descriptor may not have an addendum, the rebox below will create a
+    // descriptor with an addendum in such case.
----------------
Should read "descriptors may not ..."


================
Comment at: flang/lib/Lower/ConvertCall.cpp:1150
+    if (!shape && optionalWithShape) {
+      // If all arrays operand appear in optional positions, then none of them
+      // is allowed to be absent as per 15.5.2.12 point 3. (6). Just pick the
----------------
I think that this should say "array operands".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142695/new/

https://reviews.llvm.org/D142695