[flang-commits] [PATCH] D142695: [flang][hlfir] Lower post f77 user calls

[Valentin Clement via Phabricator via flang-commits]

clementval accepted this revision.
clementval added a comment.
This revision is now accepted and ready to land.

Looks great. Couple of typos.



================
Comment at: flang/lib/Lower/ConvertCall.cpp:611
+
+/// Structure representing a prepared dummy arguments.
+/// It holds the value to be passed in the call and any related
----------------



================
Comment at: flang/lib/Lower/ConvertCall.cpp:631
+/// Structure to help conditionnaly preparing a dummy argument based
+/// on the actual argument present.
+/// It helps "wrapping" the dummy and the clean-up information in
----------------
Maybe?


================
Comment at: flang/lib/Lower/ConvertCall.cpp:743
+  // When passing a CLASS(T) to TYPE(T), only the "T" part must be
+  // passed. Unless the entity will is a scalar passed by raw address, a
+  // new descriptor must be made to using the dummy argument type as
----------------



================
Comment at: flang/lib/Lower/ConvertCall.cpp:744
+  // passed. Unless the entity will is a scalar passed by raw address, a
+  // new descriptor must be made to using the dummy argument type as
+  // dynamic type. This must be done before any copy/copy-in because the
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142695/new/

https://reviews.llvm.org/D142695