[flang-commits] [PATCH] D141839: [flang][hlfir] Add hlfir.destroy operation.

[Valentin Clement via Phabricator via flang-commits]

clementval accepted this revision.
clementval added a comment.
This revision is now accepted and ready to land.

LG other than small nits.



================
Comment at: flang/include/flang/Optimizer/HLFIR/HLFIROps.td:507
+    allocated.
+    It is not required to create an hlfir.destroy for and expression created
+    inside an hlfir.elemental an returned in the the hlfir.yield_element.
----------------
There might be a word missing here or one that should not be here but the sentence is a bit weird to read. 


================
Comment at: flang/include/flang/Optimizer/HLFIR/HLFIROps.td:508
+    It is not required to create an hlfir.destroy for and expression created
+    inside an hlfir.elemental an returned in the the hlfir.yield_element.
+    The last use of such expression is implicit and an hlfir.destroy could
----------------



================
Comment at: flang/test/HLFIR/destroy-codegen.fir:1
+// Test hlfir.destroy code generation  and hlfir.yield_element "implicit
+// hlfir.destroy" aspect.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141839/new/

https://reviews.llvm.org/D141839