[flang-commits] [PATCH] D141510: [flang][NFC] Remove CallBuilder class

[Jean Perier via Phabricator via flang-commits]

jeanPerier created this revision.
jeanPerier added reviewers: PeteSteinfeld, clementval.
jeanPerier added a project: Flang.
Herald added subscribers: mehdi_amini, jdoerfert.
Herald added a project: All.
jeanPerier requested review of this revision.

The methods of CallBuilder do need to belong to a class.
This was made to avoid having to propagate generic lowering context
(converter, symbol mappings, location and StatementContext).

Packaging them together will actually make it harder to share the code
for user and intrinsic elemental lowering (I plan to use C++ CRTP),
and it is also misleading: one could think there is something going
with the class state while lowering the function while there is not
(and there should not be).

Removes the class and turns the methods into static functions.
Add a new CallContext class to solve the argument threading
inconvenience.

This contains no functional changes at all.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D141510

Files:
  flang/lib/Lower/ConvertCall.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141510.488234.patch
Type: text/x-patch
Size: 31985 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20230111/1031c51a/attachment-0001.bin>