[flang-commits] [PATCH] D141136: [flang] Allow and use fir.rebox in fir.global

[Slava Zakharin via Phabricator via flang-commits]

vzakhari added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1975
+    // manager inserted a builtin.unrealized_conversion_cast that was inserted
+    // and needs to be removed here.
+    if (isInGlobalOp(rewriter))
----------------
Jean, can you please explain how the `mlir::UnrealizedConversionCastOp` is actually removed?  I see that here we "ignore" it and use its operand instead of the result, but the operation should be still there.  Is it removed somewhere just because it does not have any uses?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141136/new/

https://reviews.llvm.org/D141136