[flang-commits] [PATCH] D140986: [flang][NFC] share Constant<SomeDerived> lowering

[Pete Steinfeld via Phabricator via flang-commits]

PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.
This revision is now accepted and ready to land.

Aside from a few nits in comments, all builds and tests correctly and looks good.



================
Comment at: flang/include/flang/Lower/Mangler.h:91
+// FIXME: derived type mangling is safe but not reproducible between two
+// compilation of a same file because `values().data()` is none trivial compile
+// time data structure containing pointers and vectors. In particular, this
----------------
"is none trivial" should read "is a nontrivial".


================
Comment at: flang/include/flang/Lower/Mangler.h:93
+// time data structure containing pointers and vectors. In particular, this
+// means that similar structure constructor are not "combined" into the same
+// global constant by lowering.
----------------
"constructor" should read "constructors".


================
Comment at: flang/lib/Lower/ConvertConstant.cpp:367
+      // Builtin c_ptr and c_funptr have special handling because initial
+      // value are handled for them as an extension.
+      mlir::Value addr = fir::getBase(Fortran::lower::genExtAddrInInitializer(
----------------
"value" should read "values"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140986/new/

https://reviews.llvm.org/D140986