[flang-commits] [PATCH] D143211: [flang] Avoid infinite recursion in common block check

[Leandro Lupori via Phabricator via flang-commits]

luporl added a comment.

Thanks for the quick review.

It seems that moving the common block checking task out of name resolution would require quite some work.
It's also unclear to me how to move this code out of DeclarationVisitor, that also has some functions related to name resolving.
And `CheckCommonBlocks()` is called by `ResolveNamesVisitor::FinishSpecificationPart()`.
Maybe as a helper class, that would have to be exported by Semantics/check-declarations.h?

Anyway, I guess it's better to leave that for a future patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143211/new/

https://reviews.llvm.org/D143211