[flang-commits] [flang] [flang][OpenMP] Move handling of OpenMP symbol flags to OpenMP.cpp (PR #75523)

Kiran Chandramohan via flang-commits flang-commits at lists.llvm.org
Fri Dec 15 04:11:27 PST 2023


================
@@ -4244,13 +4244,7 @@ class FirConverter : public Fortran::lower::AbstractConverter {
                       Fortran::lower::AggregateStoreMap &storeMap) {
     Fortran::lower::instantiateVariable(*this, var, localSymbols, storeMap);
     if (var.hasSymbol()) {
-      if (var.getSymbol().test(
-              Fortran::semantics::Symbol::Flag::OmpThreadprivate))
-        Fortran::lower::genThreadprivateOp(*this, var);
-
-      if (var.getSymbol().test(
-              Fortran::semantics::Symbol::Flag::OmpDeclareTarget))
-        Fortran::lower::genDeclareTargetIntGlobal(*this, var);
+      handleOpenMPSymbolProperties(*this, var);
----------------
kiranchandramohan wrote:

The braces are probably not required anymore.
Not sure about the name. If there is no better alternative, please document what the function does in the header.

https://github.com/llvm/llvm-project/pull/75523


More information about the flang-commits mailing list