[flang-commits] [flang] [flang] Separate definition of class `FirConverter` into header file (PR #74864)

[via flang-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 49b27b150b97c190dedf8b45bf991c4b811ed953 9447dddba61ad3a5441d9b0b397bde9b5876b37d -- flang/lib/Lower/FirConverter.h flang/lib/Lower/Bridge.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/flang/lib/Lower/Bridge.cpp b/flang/lib/Lower/Bridge.cpp
index 885c9307b8..5aaba23374 100644
--- a/flang/lib/Lower/Bridge.cpp
+++ b/flang/lib/Lower/Bridge.cpp
@@ -10,9 +10,9 @@
 //
 //===----------------------------------------------------------------------===//
 
+#include "flang/Lower/Bridge.h"
 #include "FirConverter.h"
 #include "flang/Lower/Allocatable.h"
-#include "flang/Lower/Bridge.h"
 #include "flang/Lower/CallInterface.h"
 #include "flang/Lower/Coarray.h"
 #include "flang/Lower/ConvertCall.h"
diff --git a/flang/lib/Lower/FirConverter.h b/flang/lib/Lower/FirConverter.h
index 51b8bd4fa0..0f639856fe 100644
--- a/flang/lib/Lower/FirConverter.h
+++ b/flang/lib/Lower/FirConverter.h
@@ -561,7 +561,8 @@ private:
   void forceControlVariableBinding(const Fortran::semantics::Symbol *sym,
                                    mlir::Value inducVar);
 
-  template <typename A> void prepareExplicitSpace(const A &forall);
+  template <typename A>
+  void prepareExplicitSpace(const A &forall);
 
   void cleanupExplicitSpace();
 
@@ -627,7 +628,8 @@ private:
 
   void genAssignment(const Fortran::evaluate::Assignment &assign);
 
-  template <typename... Op> bool isInsideOp() const;
+  template <typename... Op>
+  bool isInsideOp() const;
 
   bool isInsideHlfirForallOrWhere() const;
   bool isInsideHlfirWhere() const;
@@ -673,7 +675,8 @@ private:
 
   void setCurrentPosition(const Fortran::parser::CharBlock &position);
 
-  template <typename A> void setCurrentPositionAt(const A &parseTreeNode);
+  template <typename A>
+  void setCurrentPositionAt(const A &parseTreeNode);
 
   //===--------------------------------------------------------------------===//
   // Utility methods
@@ -707,8 +710,8 @@ private:
   void analyzeExplicitSpace(const Fortran::parser::PointerAssignmentStmt &s);
   void analyzeExplicitSpace(const Fortran::parser::WhereBodyConstruct &body);
   void analyzeExplicitSpace(const Fortran::parser::WhereConstruct &c);
-  void analyzeExplicitSpace(
-      const Fortran::parser::WhereConstruct::Elsewhere *ew);
+  void
+  analyzeExplicitSpace(const Fortran::parser::WhereConstruct::Elsewhere *ew);
   void analyzeExplicitSpace(
       const Fortran::parser::WhereConstruct::MaskedElsewhere &ew);
   void analyzeExplicitSpace(const Fortran::parser::WhereConstructStmt &ws);
@@ -1147,7 +1150,8 @@ FirConverter::isFuncResultDesignator(const Fortran::lower::SomeExpr &expr) {
 
 // Is the insertion point of the builder directly or indirectly set
 // inside any operation of type "Op"?
-template <typename... Op> bool FirConverter::isInsideOp() const {
+template <typename... Op>
+bool FirConverter::isInsideOp() const {
   mlir::Block *block = builder->getInsertionBlock();
   mlir::Operation *op = block ? block->getParentOp() : nullptr;
   while (op) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/74864