[flang-commits] [flang] [flang][OpenMP] Fix the attribute setting for OmpCommonBlock (PR #73676)

[Kiran Chandramohan via flang-commits]

kiranchandramohan wrote:

`ResolveOmpCommonBlocks` is different from other OpenMP resolutions in the sense that a new Symbol is not created for the `CommonBlock` but only for the entries in the common block. So the attribute that you are adding will go to the original instance of the Commonblock. There is no issue with this per-se, but slightly different from others where it is the new symbols that get the OpenMP specific attribute (like OmpPrivate).

Will `CheckMultipleOccurences` work correctly with this change? The code does something specific with flags that require new symbols (like private).

Are there cases that were not working without this change? If so adding them to the patch would be helpful.

https://github.com/llvm/llvm-project/pull/73676