[flang-commits] [flang] [flang] Move `genCommonBlockMember` from OpenMP to ConvertVariable, NFC (PR #74488)

Kiran Chandramohan via flang-commits flang-commits at lists.llvm.org
Tue Dec 5 09:13:59 PST 2023


================
@@ -1959,31 +1959,6 @@ static mlir::Operation *getCompareFromReductionOp(mlir::Operation *reductionOp,
   return nullptr;
 }
 
-/// The COMMON block is a global structure. \p commonValue is the base address
-/// of the COMMON block. As the offset from the symbol \p sym, generate the
-/// COMMON block member value (commonValue + offset) for the symbol.
-/// FIXME: Share the code with `instantiateCommon` in ConvertVariable.cpp.
----------------
kiranchandramohan wrote:

If you can address the FIXME that would be a good reason to move the code.

https://github.com/llvm/llvm-project/pull/74488


More information about the flang-commits mailing list