[flang-commits] [flang] [flang] Updating drivers to create data layout before semantics (PR #73301)

Andrzej Warzyński via flang-commits flang-commits at lists.llvm.org
Mon Dec 4 11:43:16 PST 2023


banach-space wrote:

The driver changes LGTM!

The stuff that's been added to CompilerInstance.cpp (e.g. `getExplicitAndImplicitAMDGPUTargetFeatures`) should be extracted to a different file and probably encapsulated with some fancy "Target info" class. But that's tangential to this change.

Thank you for addressing my comments 🙏🏻 

https://github.com/llvm/llvm-project/pull/73301


More information about the flang-commits mailing list