[flang-commits] [PATCH] D149442: [flang][hlfir] Add hlfir.region_assign and its hlfir.yield terminator

[Valentin Clement via Phabricator via flang-commits]

clementval accepted this revision.
clementval added a comment.
This revision is now accepted and ready to land.

This looks nice! Just couple of remark/questions but nothing blocking for me.



================
Comment at: flang/include/flang/Optimizer/HLFIR/HLFIROps.td:845
+      hlfir.yield %x : !fir.box<!fir.array<?x!fir.type<t>>>
+    } user_defined_assignment (%rhs_elt : !fir.ref<f32>, %lhs_elt: !fir.ref<!fir.type<t>>) {
+      %0 = fir.load %rhs_elt : !fir.ref<f32>
----------------
Maybe it's just me but I find it a bit counter intuitive to have the rhs on the left and the lhs on the right. 


================
Comment at: flang/lib/Optimizer/HLFIR/IR/HLFIROps.cpp:980
+
+mlir::ParseResult hlfir::RegionAssignOp::parse(mlir::OpAsmParser &parser,
+                                               mlir::OperationState &result) {
----------------
Was it too tricky to do it with the inlined assembly format?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149442/new/

https://reviews.llvm.org/D149442