[flang-commits] [flang] af78197 - [flang] Remove `ignoring all compiler directives` warning

V Donaldson via flang-commits flang-commits at lists.llvm.org
Fri Apr 14 16:08:36 PDT 2023


Author: V Donaldson
Date: 2023-04-14T16:08:03-07:00
New Revision: af78197857115716802189ef073f83cdac9ede15

URL: https://github.com/llvm/llvm-project/commit/af78197857115716802189ef073f83cdac9ede15
DIFF: https://github.com/llvm/llvm-project/commit/af78197857115716802189ef073f83cdac9ede15.diff

LOG: [flang] Remove `ignoring all compiler directives` warning

The explicit `ignoring all compiler directives` reminder warning is no
longer accurate.  Any similar, more accurate message is best generated
by the front end (change pending).

Added: 
    

Modified: 
    flang/lib/Lower/Bridge.cpp

Removed: 
    flang/test/Lower/compiler-directive.f90


################################################################################
diff  --git a/flang/lib/Lower/Bridge.cpp b/flang/lib/Lower/Bridge.cpp
index 2035a62128a3a..15e0d0528e2c6 100644
--- a/flang/lib/Lower/Bridge.cpp
+++ b/flang/lib/Lower/Bridge.cpp
@@ -313,12 +313,7 @@ class FirConverter : public Fortran::lower::AbstractConverter {
               [&](Fortran::lower::pft::FunctionLikeUnit &f) { lowerFunc(f); },
               [&](Fortran::lower::pft::ModuleLikeUnit &m) { lowerMod(m); },
               [&](Fortran::lower::pft::BlockDataUnit &b) {},
-              [&](Fortran::lower::pft::CompilerDirectiveUnit &d) {
-                setCurrentPosition(
-                    d.get<Fortran::parser::CompilerDirective>().source);
-                mlir::emitWarning(toLocation(),
-                                  "ignoring all compiler directives");
-              },
+              [&](Fortran::lower::pft::CompilerDirectiveUnit &d) {},
           },
           u);
     }
@@ -2003,7 +1998,7 @@ class FirConverter : public Fortran::lower::AbstractConverter {
   }
 
   void genFIR(const Fortran::parser::CompilerDirective &) {
-    mlir::emitWarning(toLocation(), "ignoring all compiler directives");
+    // TODO
   }
 
   void genFIR(const Fortran::parser::OpenACCConstruct &acc) {

diff  --git a/flang/test/Lower/compiler-directive.f90 b/flang/test/Lower/compiler-directive.f90
deleted file mode 100644
index 72d85ba5159a2..0000000000000
--- a/flang/test/Lower/compiler-directive.f90
+++ /dev/null
@@ -1,13 +0,0 @@
-! RUN: bbc %s -o - 2>&1 | FileCheck %s
-! RUN: %flang_fc1 -emit-fir %s -o - 2>&1 | FileCheck %s
-
-! CHECK: ignoring all compiler directives
-
-MODULE test_mod
-  CONTAINS
-  SUBROUTINE foo()
-    REAL :: var
-  !DIR$ VECTOR ALIGNED
-    var = 1.
-  END SUBROUTINE foo
-END MODULE test_mod


        


More information about the flang-commits mailing list