[flang-commits] [PATCH] D146485: Add tests from gfortran test suite [build files]

[Tarun Prabhu via Phabricator via flang-commits]

tarunprabhu marked 8 inline comments as done.
tarunprabhu added inline comments.


================
Comment at: Fortran/CMakeLists.txt:15
+# certain combinations of platforms and architectures.
+if (NOT WIN32)
+  if (ARCH MATCHES "x86")
----------------
kiranchandramohan wrote:
> Would it work on Mac?
I haven't checked on a Mac. Added Apple to the blacklist.


================
Comment at: Fortran/gfortran/CMakeLists.txt:1
+# Check the version of Ninja since newer versions have proper Fortran support.
+include(CheckFortranCompilerFlag)
----------------
kiranchandramohan wrote:
> Ninja or cmake version?
> 
> We should have a cmake version check (CMake 3.24.0) for the version that enabled it. Or is that what the following check does?
That comment is completely wrong. I confused it with something else. Removed. 


================
Comment at: Fortran/gfortran/CMakeLists.txt:186
+find_file(ISO_FORTRAN_C_HEADER
+  ISO_Fortran_binding.h
+  PATHS ${Fortran_PREFIX}/include/flang
----------------
kiranchandramohan wrote:
> My check-flang build did not have this and I had to copy it over. Is this copied over in the normal build or an install?
> ninja check-flang vs ninja vs ninja install.
It is definitely available with ninja install. I am not sure with just Ninja, I will check. 

Do you have any suggestions on how this can be dealt with? I think many of the flang developers only run check-flang builds, right?


================
Comment at: Fortran/gfortran/COPYING:58
+modification follow.
+

+		    GNU GENERAL PUBLIC LICENSE
----------------
kiranchandramohan wrote:
> Is this a real character?
There were several of these in the file that I copied over from the `SingleSource/Regression/C/gcc-c-torture`. I have removed all instances.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146485/new/

https://reviews.llvm.org/D146485