[flang-commits] [PATCH] D148365: [flang] Remove `ignoring all compiler directives` warning
Pete Steinfeld via Phabricator via flang-commits
flang-commits at lists.llvm.org
Fri Apr 14 12:38:59 PDT 2023
PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.
This revision is now accepted and ready to land.
I wonder if we should put out a TODO message when directives get passed to lowering. Otherwise, all builds and tests correctly and looks good.
================
Comment at: flang/lib/Lower/Bridge.cpp:2001
void genFIR(const Fortran::parser::CompilerDirective &) {
- mlir::emitWarning(toLocation(), "ignoring all compiler directives");
+ // TODO
}
----------------
Should we be emitting a TODO message here?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148365/new/
https://reviews.llvm.org/D148365
More information about the flang-commits
mailing list