[flang-commits] [PATCH] D146485: Add tests from gfortran test suite [build files]

[Kiran Chandramohan via Phabricator via flang-commits]

kiranchandramohan added a comment.

In the lit report I find the following:

  Failed Tests (2):
    test-suite :: Fortran/gfortran/regression/gfortran-regression-execute-regression__entry_23_f.test
    test-suite :: Fortran/gfortran/regression/gfortran-regression-execute-regression__findloc_8_f90.test
  
  
  Testing Time: 5.54s
    Passed: 1717
    Failed:    2

If I manually run these tests I get the following. The second one is probably a platform-specific error. If you can mark these as runtime failures then we can enable on AArch64 as well.

  $ /home/kircha02/llvm-project/build_release/bin/flang-new ../Fortran/gfortran/regression/entry_23.f -flang-experimental-exec
  $ ./a.out 
   CHAR_SUB
   len(carray(1)) 20
  Segmentation fault (core dumped)
  $ /home/kircha02/llvm-project/build_release/bin/flang-new ../Fortran/gfortran/regression/findloc_8.f90 -flang-experimental-exec
  $ ./a.out 
  
  fatal Fortran runtime error(/home/kircha02/llvm-test-suite/build/../Fortran/gfortran/regression/findloc_8.f90:9): not yet implemented: REAL/COMPLEX(KIND=10)
  Aborted (core dumped)



================
Comment at: Fortran/CMakeLists.txt:15
+# certain combinations of platforms and architectures.
+if (NOT WIN32)
+  if (ARCH MATCHES "x86")
----------------
Would it work on Mac?


================
Comment at: Fortran/CMakeLists.txt:16
+if (NOT WIN32)
+  if (ARCH MATCHES "x86")
+    add_subdirectory(gfortran)
----------------
Please enable on AArch64 as well.


================
Comment at: Fortran/gfortran/CMakeLists.txt:1
+# Check the version of Ninja since newer versions have proper Fortran support.
+include(CheckFortranCompilerFlag)
----------------
Ninja or cmake version?

We should have a cmake version check (CMake 3.24.0) for the version that enabled it. Or is that what the following check does?


================
Comment at: Fortran/gfortran/CMakeLists.txt:18
+# This option is added because as of 2023/03/20, several tests in this
+# directory have been disabled. Some of the exercise unsupported non-standard
+# extensions, others trigger a "not yet implemented" assertion while some cause
----------------



================
Comment at: Fortran/gfortran/CMakeLists.txt:62
+
+# The following cause errors if they are passed to clang via FFLAGS
+set(FLANG_ERRORING_FFLAGS
----------------



================
Comment at: Fortran/gfortran/CMakeLists.txt:186
+find_file(ISO_FORTRAN_C_HEADER
+  ISO_Fortran_binding.h
+  PATHS ${Fortran_PREFIX}/include/flang
----------------
My check-flang build did not have this and I had to copy it over. Is this copied over in the normal build or an install?
ninja check-flang vs ninja vs ninja install.


================
Comment at: Fortran/gfortran/CMakeLists.txt:217
+
+  # Remove any flags that will make clang error
+  if (DG_FFLAGS)
----------------



================
Comment at: Fortran/gfortran/COPYING:58
+modification follow.
+

+		    GNU GENERAL PUBLIC LICENSE
----------------
Is this a real character?


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146485/new/

https://reviews.llvm.org/D146485