[flang-commits] [PATCH] D148128: [flang] Fold IS_CONTIGUOUS for TYPE(*) when possible

[Peter Klausler via Phabricator via flang-commits]

klausler added inline comments.


================
Comment at: flang/lib/Evaluate/check-expression.cpp:773-775
     } else if (const auto *details{
                    ultimate.detailsIf<semantics::ObjectEntityDetails>()}) {
+      return true;
----------------
PeteSteinfeld wrote:
> I'm seeing compilation errors here because the variable `details` is not used, and my build has `-Werror=unused-variable` defined.
> 
> I'm using GCC 9.3.0.
> 
> If I change line 773 to just check against `nullptr`, everything builds and tests correctly.
I suggest recoding as `else if (ultimate.has<...>()) {`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148128/new/

https://reviews.llvm.org/D148128