[flang-commits] [PATCH] D134860: [flang] Add platform-specific intrinsic lowering

[Jean Perier via Phabricator via flang-commits]

jeanPerier added a subscriber: MatsPetersson.
jeanPerier added a comment.

I think doing this target specific dispatch in lowering is a bit early (MLIR/FIR passes relying on recognizing libm functions would also need to special case based on the target. Maybe I am wrong here though @vzakhari  or @MatsPetersson may have a better view).

I would rather suggest rewriting "hypotf" to "_hypotf" in https://github.com/flang-compiler/f18-llvm-project/blob/fir-dev/flang/lib/Optimizer/CodeGen/TargetRewrite.cpp if possible, although I understand it might be easier/cleaner from an implementation point of view to do it in IntrinsicCall.cpp. The runtime solution would also sounds fine to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134860/new/

https://reviews.llvm.org/D134860