[flang-commits] [PATCH] D133174: [flang] Add atomic_fetch_or to the list of intrinsics

[Katherine Rasmussen via Phabricator via flang-commits]

ktras marked 2 inline comments as done.
ktras added inline comments.


================
Comment at: flang/module/iso_fortran_env.f90:20
+    team_type => __builtin_team_type, &
+    __builtin_atomic_int_kind, &
+    __builtin_atomic_logical_kind
----------------
jeanPerier wrote:
> Is there a reason to define new parameters instead of doing renaming here (e.g., `atomic_int_kind 
>  => __builtin_atomic_int_kind`) ?
> 
> If renames are possible, I think they should be favored because they avoid "spilling" the builtin symbols. With the current patch, a user using iso_fortran_env could directly use `__builtin_atomic_int_kind` and `__builtin_atomic_logical_kind`, and I do not think we should allow that to make it impossible for users to start relying on the builtin names for any weird reason as if it was an extension.
> 
No, there is no reason to define new parameters, but I didn't even think about taking out the original definition fully. Thanks for the great feedback!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133174/new/

https://reviews.llvm.org/D133174