[flang-commits] [PATCH] D133174: [flang] Add atomic_fetch_or to the list of intrinsics

Mon Sep 26 10:20:12 PDT 2022

ktras added a comment.

@jeanPerier Thank you for the feedback! I think the idea to use `flang/module/__fortran_builtins.f90` seems like a great idea and I will pursue that option. Thank you for pointing out how that could be useful in this case.

================
Comment at: flang/lib/Evaluate/intrinsics.cpp:1593
+        } else if (ExtractCoarrayRef(*arg)) {
+          argOk = true;
+        } else {
----------------
jeanPerier wrote:
> I am not well versed in coarrays, and the standard phrasing "shall be a scalar coarray or coindexed object" is a bit ambiguous to me. Are you sure the "scalar" part does not also apply to coindexed objects ? It is not entirely clear to me why it would apply on Corarray and not coarray references. 
@jeanPerier, As you saw, the interpretation I took is that in that sentence in the standard, `scalar` only modifies `coarray` and not `coindexed-object`, but I am not sure that this interpretation is correct. I can see your point that this interpretation doesn't make as much sense. @rouson, can you give feedback on this coarray question? Do you know whether "shall be a scalar coarray or coindexed object" in 16.9.25 in the 2018 standard means that a `coindexed-object` shall also be `scalar`? Or just if it is a coarray?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133174/new/

https://reviews.llvm.org/D133174