[flang-commits] [PATCH] D134543: [flang] Lowers calls to procedure with CONTIGUOUS assumed shape dummies

[Pete Steinfeld via Phabricator via flang-commits]

PeteSteinfeld added a comment.

All builds and tests correctly and looks good, except for the two nits I mentioned.  But I don't understand this code very well.   @clementval should take a look and provide feedback.



================
Comment at: flang/lib/Lower/ConvertExpr.cpp:3063
   /// copying has to be conditional at runtime.
-  ExtValue prepareActualToBaseAddressLike(
+  /// If the actual argument may be dynamically absent, returns and additional
+  /// boolean mlir::Value that if trues means that the actual argument is
----------------
Did you mean to say "return an"?


================
Comment at: flang/lib/Lower/ConvertExpr.cpp:3297
+                *expr, converter.getFoldingContext())) {
+          // If the expression is a PDT, or a polymophic entity, or an assumed
+          // rank, it cannot currently be safely handled by
----------------
"polymorphic"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134543/new/

https://reviews.llvm.org/D134543