[flang-commits] [PATCH] D129616: Lower F08 bitwise-reduction intrinsics (IALL, IANY, IPARITY)

[Tarun Prabhu via Phabricator via flang-commits]

tarunprabhu added a comment.

In D129616#3798995 <https://reviews.llvm.org/D129616#3798995>, @jeanPerier wrote:

> Thanks @tarunprabhu for addressing the previous comments, I agree with @peixin that some lit tests should be added in `flang/test/Lower/Intrinsics` and that it would make sense to move the `EXPAND_AND_QUOTE` macro definition in `flang/Optimizer/Builder/Runtime/RTBuilder.h`.
>
> Otherwise LGTM.



In D129616#3794813 <https://reviews.llvm.org/D129616#3794813>, @peixin wrote:

> No test cases?

Bah! Sorry, my mistake. I didn't check the diff properly. The tests were there, but did not get included in the diff.

> Can the runtime support the following special case?
> IALL: If ARRAY has size zero the result value is equal to NOT (INT (0, KIND (ARRAY))).

I just ran a simple test with the  `-flang-experimental-exec` flag and it seems to give the expected result. However, I am not familiar with the runtime, so someone else will have to give you a definitive answer, I'm afraid.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129616/new/

https://reviews.llvm.org/D129616