[flang-commits] [PATCH] D126721: [flang] Add lcobound and ucobound to the list of intrinsics

[Katherine Rasmussen via Phabricator via flang-commits]

ktras added inline comments.


================
Comment at: flang/lib/Evaluate/intrinsics.cpp:192
     dimRemovedOrScalar, // rank(array)-1 (less DIM) or scalar
+    dimOrRankOne, // scalar if DIM= argument is present, else rank one array
     locReduced, // vector(1:rank) if no DIM= argument, else rank(array)-1
----------------
klausler wrote:
> It took me several tries to understand the intent here, since the result doesn't depend on the value of the DIM= argument, only its presence, despite the name.  Maybe something more self-evident could be used for the name, like "vectorIfNoDim" or "scalarIfDim".
Thanks @klausler for the feedback. I have updated the name to `scalarIfDim` to make its purpose more clear.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126721/new/

https://reviews.llvm.org/D126721