[flang-commits] [PATCH] D136955: [flang][NFC] move constant lowering into its own unit

[Jean Perier via Phabricator via flang-commits]

jeanPerier updated this revision to Diff 471927.
jeanPerier marked 3 inline comments as done.
jeanPerier added a comment.

Fix typos in comments and remove complex case from convertToAttribute
(I was mislead into thinking complex could be converted to attribute
that way, but this code was actually unreachable and does not work
as pointed out in the DenseGlobalBuilder comment that I had moved
and not read well enough). Better to remove it IMHO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136955/new/

https://reviews.llvm.org/D136955

Files:
  flang/include/flang/Lower/ConvertConstant.h
  flang/include/flang/Lower/ConvertExpr.h
  flang/lib/Lower/CMakeLists.txt
  flang/lib/Lower/ConvertConstant.cpp
  flang/lib/Lower/ConvertExpr.cpp
  flang/lib/Lower/ConvertVariable.cpp
  flang/test/Lower/array-substring.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136955.471927.patch
Type: text/x-patch
Size: 53591 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20221031/aad7be46/attachment-0001.bin>