[flang-commits] [PATCH] D136979: [flang] Fix pointer definition semantic checking via refactoring

[Peter Klausler via Phabricator via flang-commits]

klausler created this revision.
klausler added a reviewer: PeteSteinfeld.
klausler added a project: Flang.
Herald added a subscriber: jdoerfert.
Herald added a reviewer: sscalpone.
Herald added a project: All.
klausler requested review of this revision.

The infrastructure in semantics that is used to check that the
left-hand sides of normal assignment statements are really definable
variables was not being used to check whether the LHSs of pointer assignments
are modifiable, and so most cases of unmodifiable pointers are left
undiagnosed.  Rework the semantics checking for pointer assignments,
NULLIFY statements, pointer dummy arguments, &c. so that cases of
unmodifiable pointers are properly caught.  This has been done
by extracting all the various definability checking code that has
been implemented for different contexts in Fortran into one new
facility.

The new consolidated definability checking code returns messages
meant to be attached as "because: " explanations to context-dependent
errors like "left-hand side of assignment is not definable".
These new error message texts and their attached explanations
affect many existing tests, which have been updated.  The testing
infrastructure was extended by another patch to properly compare
warnings and explanatory messages, which had been ignored until
recently.


https://reviews.llvm.org/D136979

Files:
  flang/docs/Parsing.md
  flang/include/flang/Parser/message.h
  flang/include/flang/Semantics/tools.h
  flang/lib/Semantics/CMakeLists.txt
  flang/lib/Semantics/assignment.cpp
  flang/lib/Semantics/assignment.h
  flang/lib/Semantics/check-call.cpp
  flang/lib/Semantics/check-declarations.cpp
  flang/lib/Semantics/check-io.cpp
  flang/lib/Semantics/check-nullify.cpp
  flang/lib/Semantics/check-omp-structure.cpp
  flang/lib/Semantics/data-to-inits.cpp
  flang/lib/Semantics/definable.cpp
  flang/lib/Semantics/definable.h
  flang/lib/Semantics/expression.cpp
  flang/lib/Semantics/pointer-assignment.cpp
  flang/lib/Semantics/pointer-assignment.h
  flang/lib/Semantics/resolve-names.cpp
  flang/lib/Semantics/tools.cpp
  flang/test/Semantics/OpenMP/omp-lastprivate01.f90
  flang/test/Semantics/OpenMP/omp-reduction04.f90
  flang/test/Semantics/assign02.f90
  flang/test/Semantics/assign03.f90
  flang/test/Semantics/assign04.f90
  flang/test/Semantics/atomic03.f90
  flang/test/Semantics/atomic04.f90
  flang/test/Semantics/atomic05.f90
  flang/test/Semantics/atomic07.f90
  flang/test/Semantics/atomic10.f90
  flang/test/Semantics/call03.f90
  flang/test/Semantics/call06.f90
  flang/test/Semantics/call10.f90
  flang/test/Semantics/call12.f90
  flang/test/Semantics/collectives01.f90
  flang/test/Semantics/collectives02.f90
  flang/test/Semantics/collectives03.f90
  flang/test/Semantics/collectives04.f90
  flang/test/Semantics/deallocate05.f90
  flang/test/Semantics/io01.f90
  flang/test/Semantics/io02.f90
  flang/test/Semantics/io03.f90
  flang/test/Semantics/io04.f90
  flang/test/Semantics/io05.f90
  flang/test/Semantics/io06.f90
  flang/test/Semantics/modifiable01.f90
  flang/test/Semantics/nullify02.f90
  flang/test/Semantics/random-seed.f90
  flang/test/Semantics/resolve35.f90
  flang/test/Semantics/resolve57.f90
  flang/test/Semantics/resolve62.f90
  flang/test/Semantics/resolve76.f90
  flang/test/Semantics/selecttype03.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136979.471642.patch
Type: text/x-patch
Size: 92725 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20221028/28717791/attachment-0001.bin>