[flang-commits] [PATCH] D136606: [flang] Fix building against clang dylib

[Andrzej Warzynski via Phabricator via flang-commits]

awarzynski added a comment.
Herald added a subscriber: jdoerfert.

In D136606#3890328 <https://reviews.llvm.org/D136606#3890328>, @MaskRay wrote:

> Which build does this patch fix? My `-DLLVM_ENABLE_PROJECTS='llvm;clang;mlir;flang' -DLLVM_LINK_LLVM_DYLIB=on` build `ninja check-flang` works without this patch.
>
> Note also that lldb has some clangBasic uses without the clang-cpp dispatch.

Ah, we should've looked at LLDB in search for inspiration - they do indeed have a nice solution :) I think that the approach in this patch is fine and we can improve things later. I created https://github.com/llvm/llvm-project/issues/58663 to track this. Thanks for the pointer @MaskRay !


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136606/new/

https://reviews.llvm.org/D136606