[flang-commits] [PATCH] D136428: [flang] add hlfir::FortranEntity class

[Jean Perier via Phabricator via flang-commits]

jeanPerier added a comment.

Thanks for the review Valentin.



================
Comment at: flang/include/flang/Optimizer/Builder/HLFIRTools.h:53
+
+/// Wrapper over an mlir::Value that can be viewed as a Fortran entity.
+/// This provides some Fortran specific helpers as well as a guarantee
----------------
clementval wrote:
> 
I disagree on this one, the "m" in "mlir" here is pronounced individually, and the consonant "M", when pronounced as an individual letter, begins with a vowel sound. I believe the rule is to use "an" when the next sounds is a  vowel sound.

In MLIR directory:
`find  ./ -type f -print0 | xargs -0 grep --text -i ' an mlir' | wc -l` -> 183

`find  ./ -type f -print0 | xargs -0 grep --text -i ' a mlir' | wc -l` -> 34


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136428/new/

https://reviews.llvm.org/D136428