[flang-commits] [PATCH] D136428: [flang] add hlfir::FortranEntity class

[Valentin Clement via Phabricator via flang-commits]

clementval accepted this revision.
clementval added a comment.
This revision is now accepted and ready to land.

LGTM. Couple of typos.



================
Comment at: flang/include/flang/Optimizer/Builder/HLFIRTools.h:26
+
+/// Is this an SSA value type for the value of a Fortran expression ?
+inline bool isFortranValueType(mlir::Type type) {
----------------



================
Comment at: flang/include/flang/Optimizer/Builder/HLFIRTools.h:31
+
+/// Is this the value of a Fortran expression in an SSA value form ?
+inline bool isFortranValue(mlir::Value value) {
----------------
Same for other comments below


================
Comment at: flang/include/flang/Optimizer/Builder/HLFIRTools.h:53
+
+/// Wrapper over an mlir::Value that can be viewed as a Fortran entity.
+/// This provides some Fortran specific helpers as well as a guarantee
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136428/new/

https://reviews.llvm.org/D136428