[flang-commits] [PATCH] D135853: [flang] Rename hypotf on MSVC platforms

[Slava Zakharin via Phabricator via flang-commits]

vzakhari added a comment.

Sorry for the delay.  It looks good to me in general.



================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:3451
+      mlir::RewritePatternSet patterns(context);
+      patterns.insert<RenameMSVCLibmCallees, RenameMSVCLibmFuncs>(context);
+
----------------
Can you please combine this with the patterns/conversion above?  I.e. add the MSVC conversion patterns into `pattern` and get rid of the separate `applyPartialConversion` below?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135853/new/

https://reviews.llvm.org/D135853