[flang-commits] [PATCH] D136151: [flang] Introduce FortranVariableOpInterface for ops creating variable

[Pete Steinfeld via Phabricator via flang-commits]

PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.

Looking good!  Aside from a few nits, all builds and tests correctly and looks good.



================
Comment at: flang/include/flang/Optimizer/Dialect/FortranVariableInterface.td:9
+//
+// This file define an interface for operations defining Fortran variables.
+//
----------------
Should read "This file defines"


================
Comment at: flang/include/flang/Optimizer/Dialect/FortranVariableInterface.td:21
+  let description = [{
+    Interface for operation that creates Fortran like variables in order to
+    query about all their Fortran properties.
----------------
Should this be "Interface for operations that create"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136151/new/

https://reviews.llvm.org/D136151