[flang-commits] [PATCH] D136104: [flang] Add check for constraints on synchronization-stmts

Peter Klausler via Phabricator via flang-commits flang-commits at lists.llvm.org
Mon Oct 17 16:37:54 PDT 2022


klausler added inline comments.


================
Comment at: flang/lib/Semantics/check-coarray.cpp:85
 
+static void CheckCoindexedStatOrErrmsg(SemanticsContext &context,
+    const parser::StatOrErrmsg &statOrErrmsg, const std::string &listName) {
----------------
Is there a numbered constraint in the standard that should appear in a comment here?


================
Comment at: flang/lib/Semantics/check-coarray.cpp:87
+    const parser::StatOrErrmsg &statOrErrmsg, const std::string &listName) {
+  auto CoindexedCheck = [&](const auto &statOrErrmsg) {
+    if (const auto *expr{GetExpr(context, statOrErrmsg)}) {
----------------
braced initialization please


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136104/new/

https://reviews.llvm.org/D136104



More information about the flang-commits mailing list