[flang-commits] [PATCH] D135959: [flang] Introduce option to lower expression to HLFIR

Jean Perier via Phabricator via flang-commits flang-commits at lists.llvm.org
Fri Oct 14 08:13:48 PDT 2022


jeanPerier added inline comments.


================
Comment at: flang/include/flang/Lower/AbstractConverter.h:131
                                          StatementContext &context,
-                                         mlir::Location *loc = nullptr) = 0;
 
----------------
clementval wrote:
> Is this change related?
Yes, I renamed the argument name in the override definition in lib/Lower/Bridge.cpp, so it seemed more consistent to also changed it in the abstract declaration.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135959/new/

https://reviews.llvm.org/D135959



More information about the flang-commits mailing list